Messages in this thread | | | Date | Sat, 25 Mar 2017 20:05:46 -0700 (PDT) | Subject | Re: [RESEND PATCH 1/3] net: hns: fix uninitialized data use | From | David Miller <> |
| |
From: Arnd Bergmann <arnd@arndb.de> Date: Fri, 24 Mar 2017 23:02:49 +0100
> When dev_dbg() is enabled, we print uninitialized data, as gcc-7.0.1 > now points out: > > ethernet/hisilicon/hns/hns_dsaf_main.c: In function 'hns_dsaf_set_promisc_tcam': > ethernet/hisilicon/hns/hns_dsaf_main.c:2947:75: error: 'tbl_tcam_data.low.val' may be used uninitialized in this function [-Werror=maybe-uninitialized] > ethernet/hisilicon/hns/hns_dsaf_main.c:2947:75: error: 'tbl_tcam_data.high.val' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > We also pass the data into hns_dsaf_tcam_mc_cfg(), which might later > use it (not sure about that), so it seems safer to just always initialize > the tbl_tcam_data structure. > > Fixes: 1f5fa2dd1cfa ("net: hns: fix for promisc mode in HNS driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
| |