Messages in this thread | | | Subject | Re: [RESEND PATCH 3/3] infiniband: hns: avoid gcc-7.0.1 warning for uninitialized data | From | Doug Ledford <> | Date | Tue, 25 Apr 2017 15:19:03 -0400 |
| |
On Fri, 2017-03-24 at 23:02 +0100, Arnd Bergmann wrote: > hns_roce_v1_cq_set_ci() calls roce_set_bit() on an uninitialized > field, > which will then change only a few of its bits, causing a warning with > the latest gcc: > > infiniband/hw/hns/hns_roce_hw_v1.c: In function > 'hns_roce_v1_cq_set_ci': > infiniband/hw/hns/hns_roce_hw_v1.c:1854:23: error: 'doorbell[1]' is > used uninitialized in this function [-Werror=uninitialized] > roce_set_bit(doorbell[1], ROCEE_DB_OTHERS_H_ROCEE_DB_OTH_HW_SYNS_S, > 1); > > The code is actually correct since we always set all bits of the > port_vlan field, but gcc correctly points out that the first > access does contain uninitialized data. > > This initializes the field to zero first before setting the > individual bits. > > Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, applied.
-- Doug Ledford <dledford@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
| |