| Date | Thu, 16 Mar 2017 17:25:31 -0700 | From | Andi Kleen <> | Subject | Re: [patch 6/7] x86/pci/mmcfg: Include 32/64 bit code into shared code |
| |
> --- a/arch/x86/pci/mmconfig-shared.c > +++ b/arch/x86/pci/mmconfig-shared.c > @@ -24,6 +24,12 @@ > > #define PREFIX "PCI: " > > +#ifdef CONFIG_X86_64 > +# include "mmconfig_64.c" > +#else > +# include "mmconfig_32.c" > +#endif
This seems like a bad hack. If you want to access something from multiple files just make it global, don't play preprocessor tricks.
-Andi
|