lkml.org 
[lkml]   [2017]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero
Date
From: Colin Ian King <colin.king@canonical.com>

The check on rcode >= 0 is always true because rcode is unsigned
and can never be less than zero. Remove the redundant check.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/aacraid/aachba.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 3b5ddf4..ddfd726 100644
--- a/drivers/scsi/aacraid/aachba.c
+++ b/drivers/scsi/aacraid/aachba.c
@@ -1848,7 +1848,7 @@ int aac_report_phys_luns(struct aac_dev *dev, struct fib *fibptr, int rescan)
FsaNormal, 1, 1, NULL, NULL);

/* analyse data */
- if (rcode >= 0 && phys_luns->resp_flag == 2) {
+ if (phys_luns->resp_flag == 2) {
/* ok and extended reporting */
aac_update_hba_map(dev, phys_luns, rescan);
}
--
2.10.2
\
 
 \ /
  Last update: 2017-02-07 12:29    [W:0.054 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site