Messages in this thread | | | Date | Sun, 5 Feb 2017 11:39:43 +0100 | From | Greg KH <> | Subject | Re: [PATCH] staging: fbtft: fbtft-bus.c: Fix checkpatch error |
| |
On Sat, Feb 04, 2017 at 01:42:48PM +0900, Youngdo Lee wrote: > Fix checkpatch error: > ERROR: space prohibited before that close parenthesis ')' > > Signed-off-by: Youngdo Lee <paul.ydlee@gmail.com> > --- > drivers/staging/fbtft/fbtft-bus.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c > index ec45043..3ce265d 100644 > --- a/drivers/staging/fbtft/fbtft-bus.c > +++ b/drivers/staging/fbtft/fbtft-bus.c > @@ -10,6 +10,7 @@ > * > *****************************************************************************/ > > +#define nop_modifier(expr) (expr)
What?
> #define define_fbtft_write_reg(func, type, modifier) \ > void func(struct fbtft_par *par, int len, ...) \ > { \ > @@ -68,9 +69,9 @@ void func(struct fbtft_par *par, int len, ...) \ > } \ > EXPORT_SYMBOL(func); > > -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, ) > +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, nop_modifier)
That's really odd. Don't do crazy things like this to fix odd code. Fix up the code to not do such looney things in the first place.
thanks,
greg k-h
| |