lkml.org 
[lkml]   [2017]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 177/319] driver core: Delete an unnecessary check before the function call "put_device"
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>

    commit 5f0163a5ee9cc7c59751768bdfd94a73186debba upstream.

    The put_device() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    [wt: backported only to ease next patch as suggested by Jiri]

    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/base/core.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/base/core.c b/drivers/base/core.c
    index 2a19097..d92ecf3 100644
    --- a/drivers/base/core.c
    +++ b/drivers/base/core.c
    @@ -1138,8 +1138,7 @@ done:
    kobject_del(&dev->kobj);
    Error:
    cleanup_device_parent(dev);
    - if (parent)
    - put_device(parent);
    + put_device(parent);
    name_error:
    kfree(dev->p);
    dev->p = NULL;
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-02-05 20:42    [W:4.203 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site