Messages in this thread Patch in this message | | | From | Javier Martinez Canillas <> | Subject | [PATCH 1/2] mfd: retu: Add OF device ID table | Date | Tue, 21 Feb 2017 10:34:34 -0300 |
| |
The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have a OF device ID table if the devices are registered via OF.
The compatible strings don't have a vendor prefix because that's how it's used currently, and changing this will be a Device Tree ABI break.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> ---
drivers/mfd/retu-mfd.c | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/drivers/mfd/retu-mfd.c b/drivers/mfd/retu-mfd.c index d4c114abeb75..b47ba6a63b7e 100644 --- a/drivers/mfd/retu-mfd.c +++ b/drivers/mfd/retu-mfd.c @@ -308,9 +308,17 @@ static const struct i2c_device_id retu_id[] = { }; MODULE_DEVICE_TABLE(i2c, retu_id); +static const struct of_device_id retu_of_match[] = { + { .compatible = "retu-mfd" }, + { .compatible = "tahvo-mfd" }, + { } +}; +MODULE_DEVICE_TABLE(of, retu_of_match); + static struct i2c_driver retu_driver = { .driver = { .name = "retu-mfd", + .of_match_table = of_match_ptr(retu_of_match), }, .probe = retu_probe, .remove = retu_remove, -- 2.9.3
| |