| Date | Wed, 1 Feb 2017 11:37:00 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts |
| |
On Tue, 27 Dec 2016 23:16:08 +0900 Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> Account lost messages in pritk-safe and printk-safe-nmi > contexts and report those numbers during printk_safe_flush(). > > The patch also moves lost message counter to struct > `printk_safe_seq_buf' instead of having dedicated static > counters - this simplifies the code. > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > ---
This looks fine, but I'm curious if you tested it. That is, added a bunch of printks to overflow the buffer. IIRC, I did it to the original nmi code. If you haven't you may want to just to make sure it works. I can also test it too if I get some time.
-- Steve
|