lkml.org 
[lkml]   [2017]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv7 8/8] printk: convert the rest to printk-safe
    On Tue 2016-12-27 23:16:11, Sergey Senozhatsky wrote:
    > This patch converts the rest of logbuf users (which are
    > out of printk recursion case, but can deadlock in printk).
    > To make printk-safe usage easier the patch introduces 4
    > helper macros:
    > - logbuf_lock_irq()/logbuf_unlock_irq()
    > lock/unlock the logbuf lock and disable/enable local IRQ
    >
    > - logbuf_lock_irqsave(flags)/logbuf_unlock_irqrestore(flags)
    > lock/unlock the logbuf lock and saves/restores local IRQ state
    >
    > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

    I like that it is so straigforward using the new macros. It is great
    that you discovered this before we finished the patchset.

    Reviewed-by: Petr Mladek <pmladek@suse.com>

    Best Regards,
    Petr

    PS: All patches look fine to me. I am going to do some tests before
    I could say a final word. I guess that it will be fine and we will
    be able to push it to linux-next.

    \
     
     \ /
      Last update: 2017-01-04 17:29    [W:5.510 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site