Messages in this thread Patch in this message | | | From | SF Markus Elfring <> | Subject | [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory() | Date | Wed, 6 Dec 2017 13:06:32 +0100 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Wed, 6 Dec 2017 13:03:21 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/usb/misc/emi26.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/misc/emi26.c b/drivers/usb/misc/emi26.c index 24d841850e05..654e93857d65 100644 --- a/drivers/usb/misc/emi26.c +++ b/drivers/usb/misc/emi26.c @@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int address, int result; unsigned char *buffer = kmemdup(data, length, GFP_KERNEL); - if (!buffer) { - dev_err(&dev->dev, "kmalloc(%d) failed.\n", length); + if (!buffer) return -ENOMEM; - } + /* Note: usb_control_msg returns negative value on error or length of the * data that was written! */ result = usb_control_msg (dev, usb_sndctrlpipe(dev, 0), request, 0x40, address, 0, buffer, length, 300); -- 2.15.1
| |