| Date | Wed, 15 Nov 2017 10:54:51 +0000 | From | Mark Brown <> | Subject | Re: [PATCH AUTOSEL for 4.9 44/56] ASoC: dwc: Fix PIO mode initialization |
| |
On Wed, Nov 15, 2017 at 02:45:45AM +0000, alexander.levin@verizon.com wrote:
> We can no longer rely on the return value of > devm_snd_dmaengine_pcm_register(...) to check if the DMA > handle is declared in the DT.
> Previously this check activated PIO mode but currently > dma_request_chan returns either a valid channel or -EPROBE_DEFER.
So when did the corresponding change to the dmaengine API go in?
> In order to activate PIO mode check instead if the interrupt > line is declared. This reflects better what is documented in > the DT bindings (see Documentation/devicetree/bindings/sound/ > designware-i2s.txt).
> Also, initialize use_pio variable which was never being set > causing PIO mode to never work.
Though if PIO mode never worked presumably this isn't that urgent... [unhandled content-type:application/pgp-signature] |