Messages in this thread Patch in this message | | | From | Arvind Yadav <> | Subject | [PATCH] media: imon: Fix null-ptr-deref in imon_probe | Date | Mon, 9 Oct 2017 23:44:48 +0530 |
| |
It seems that the return value of usb_ifnum_to_if() can be NULL and needs to be checked.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- This bug report by Andrey Konovalov usb/media/imon: null-ptr-deref in imon_probe
drivers/media/rc/imon.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c index 7b3f31c..0c46155 100644 --- a/drivers/media/rc/imon.c +++ b/drivers/media/rc/imon.c @@ -2517,6 +2517,11 @@ static int imon_probe(struct usb_interface *interface, mutex_lock(&driver_lock); first_if = usb_ifnum_to_if(usbdev, 0); + if (!first_if) { + ret = -ENODEV; + goto fail; + } + first_if_ctx = usb_get_intfdata(first_if); if (ifnum == 0) { -- 2.7.4
| |