lkml.org 
[lkml]   [2017]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectA question of "cond_resched_lock" called in atomic context
Date
I have seen some drivers or file systems calls "cond_resched_lock" when 
holding a spinlock.
An example is in fs/ocfs2/dlm/dlmdomain.c:
dlm_migrate_all_locks (acquire the spinlock)
cond_resched_lock

I find that "cond_resched_lock" has two functions: "___might_sleep" and
"__cond_resched_lock".
I know that "__cond_resched_lock" is safe and okay to be called when
holding a spinlock.
However, I think "___might_sleep" can be removed, because it prints
error messages in this situation, but it is safe in fact.

Am I right? I am looking forward to your comments :)


Thanks,
Jia-Ju Bai



\
 
 \ /
  Last update: 2017-10-07 12:35    [W:0.025 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site