Messages in this thread | | | Subject | Re: [PATCH v3 16/33] tracing: Generalize per-element hist trigger data | From | Tom Zanussi <> | Date | Wed, 04 Oct 2017 14:22:26 -0500 |
| |
On Wed, 2017-10-04 at 13:34 -0400, Steven Rostedt wrote: > On Fri, 22 Sep 2017 14:59:56 -0500 > Tom Zanussi <tom.zanussi@linux.intel.com> wrote: > > > @@ -1742,7 +1746,8 @@ static void hist_trigger_stacktrace_print(struct seq_file *m, > > seq_printf(m, "%s: [%llx] %-55s", field_name, > > uval, str); > > } else if (key_field->flags & HIST_FIELD_FL_EXECNAME) { > > - char *comm = elt->private_data; > > + struct hist_elt_data *elt_data = elt->private_data; > > Weren't we going to add a "if (WARN_ON_ONCE(!elt_data)) return;" here? >
This I did miss, will update ;-)
Tom
> -- Steve > > > + char *comm = elt_data->comm; > > > > uval = *(u64 *)(key + key_field->offset); > > seq_printf(m, "%s: %-16s[%10llu]", field_name, > > --
| |