lkml.org 
[lkml]   [2017]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 16/33] tracing: Generalize per-element hist trigger data
On Fri, 22 Sep 2017 14:59:56 -0500
Tom Zanussi <tom.zanussi@linux.intel.com> wrote:

> @@ -1742,7 +1746,8 @@ static void hist_trigger_stacktrace_print(struct seq_file *m,
> seq_printf(m, "%s: [%llx] %-55s", field_name,
> uval, str);
> } else if (key_field->flags & HIST_FIELD_FL_EXECNAME) {
> - char *comm = elt->private_data;
> + struct hist_elt_data *elt_data = elt->private_data;

Weren't we going to add a "if (WARN_ON_ONCE(!elt_data)) return;" here?

-- Steve

> + char *comm = elt_data->comm;
>
> uval = *(u64 *)(key + key_field->offset);
> seq_printf(m, "%s: %-16s[%10llu]", field_name,
> --

\
 
 \ /
  Last update: 2017-10-04 19:35    [W:0.234 / U:11.636 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site