Messages in this thread | | | Subject | Re: [PATCH 1/2] f2fs: add missing quota_initialize in f2fs_set_acl | From | Chao Yu <> | Date | Wed, 25 Oct 2017 13:57:42 +0800 |
| |
On 2017/10/25 13:44, Jaegeuk Kim wrote: > On 10/24, Chao Yu wrote: >> On 2017/10/24 6:14, Jaegeuk Kim wrote: >>> This patch adds to call quota_intialize in f2fs_set_acl. >>> >>> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> >>> --- >>> fs/f2fs/acl.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c >>> index 436b3a1464d9..f6471f9d707e 100644 >>> --- a/fs/f2fs/acl.c >>> +++ b/fs/f2fs/acl.c >>> @@ -209,6 +209,10 @@ static int __f2fs_set_acl(struct inode *inode, int type, >>> int error; >>> umode_t mode = inode->i_mode; >>> >>> + error = dquot_initialize(inode); >>> + if (error) >>> + return error; >> >> Could you move this to f2fs_setxattr, and also add missing dquot_initialize in >> unlink and rename like ext4? > > I've checked that f2fs_unlink and f2fs_rename are calling dquot_initialize().
ext4_unlink:
retval = dquot_initialize(dir); if (retval) return retval; retval = dquot_initialize(d_inode(dentry)); if (retval) return retval;
f2fs_unlink:
err = dquot_initialize(dir); if (err) return err;
ext4_rename
retval = dquot_initialize(old.dir); if (retval) return retval; retval = dquot_initialize(new.dir); if (retval) return retval;
/* Initialize quotas before so that eventual writes go * in separate transaction */ if (new.inode) { retval = dquot_initialize(new.inode); if (retval) return retval; }
f2fs_rename
err = dquot_initialize(old_dir); if (err) goto out;
err = dquot_initialize(new_dir); if (err) goto out;
ext4 call one more dquot_initialize than f2fs, I didn't look into this in detail, but it's better to check that. :)
Thanks, > > Thanks, > >> >> Thanks, >> >>> + >>> switch (type) { >>> case ACL_TYPE_ACCESS: >>> name_index = F2FS_XATTR_INDEX_POSIX_ACL_ACCESS; >>> > > . >
| |