Messages in this thread | | | Date | Wed, 25 Oct 2017 07:44:19 +0200 | From | Jaegeuk Kim <> | Subject | Re: [PATCH 1/2] f2fs: add missing quota_initialize in f2fs_set_acl |
| |
On 10/24, Chao Yu wrote: > On 2017/10/24 6:14, Jaegeuk Kim wrote: > > This patch adds to call quota_intialize in f2fs_set_acl. > > > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > > --- > > fs/f2fs/acl.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c > > index 436b3a1464d9..f6471f9d707e 100644 > > --- a/fs/f2fs/acl.c > > +++ b/fs/f2fs/acl.c > > @@ -209,6 +209,10 @@ static int __f2fs_set_acl(struct inode *inode, int type, > > int error; > > umode_t mode = inode->i_mode; > > > > + error = dquot_initialize(inode); > > + if (error) > > + return error; > > Could you move this to f2fs_setxattr, and also add missing dquot_initialize in > unlink and rename like ext4?
I've checked that f2fs_unlink and f2fs_rename are calling dquot_initialize().
Thanks,
> > Thanks, > > > + > > switch (type) { > > case ACL_TYPE_ACCESS: > > name_index = F2FS_XATTR_INDEX_POSIX_ACL_ACCESS; > >
| |