lkml.org 
[lkml]   [2017]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4.4 20/41] bsg-lib: dont free job in bsg_prepare_job
From
Date
On Tue, 2017-10-03 at 14:21 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
>
> ------------------
>
> From: Christoph Hellwig <hch@lst.de>
>
> commit f507b54dccfd8000c517d740bc45f20c74532d18 upstream.
>
> The job structure is allocated as part of the request, so we should not
> free it in the error path of bsg_prepare_job.

That function doesn't exist here (it was introduced in 4.13). Instead,
this backport has modified bsg_create_job(), creating a leak. Please
revert this on the 3.18, 4.4 and 4.9 stable branches.

Ben.

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
>  block/bsg-lib.c |    1 -
>  1 file changed, 1 deletion(-)
>
> --- a/block/bsg-lib.c
> +++ b/block/bsg-lib.c
> @@ -147,7 +147,6 @@ static int bsg_create_job(struct device
>  failjob_rls_rqst_payload:
>   kfree(job->request_payload.sg_list);
>  failjob_rls_job:
> - kfree(job);
>   return -ENOMEM;
>  }
>  
>
>
>
--
Ben Hutchings
Software Developer, Codethink Ltd.

\
 
 \ /
  Last update: 2017-10-16 18:33    [W:0.231 / U:1.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site