Messages in this thread Patch in this message | | | Date | Tue, 10 Oct 2017 03:59:54 -0700 | From | tip-bot for Brendan Jackman <> | Subject | [tip:sched/core] sched/fair: Remove unnecessary comparison with -1 |
| |
Commit-ID: e90381eaecf6d59c60fe396838e0e99789531419 Gitweb: https://git.kernel.org/tip/e90381eaecf6d59c60fe396838e0e99789531419 Author: Brendan Jackman <brendan.jackman@arm.com> AuthorDate: Thu, 5 Oct 2017 12:45:13 +0100 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Tue, 10 Oct 2017 11:45:34 +0200
sched/fair: Remove unnecessary comparison with -1
Since commit:
83a0a96a5f26 ("sched/fair: Leverage the idle state info when choosing the "idlest" cpu")
find_idlest_group_cpu() (formerly find_idlest_cpu) no longer returns -1, so we can simplify the checking of the return value in find_idlest_cpu().
Signed-off-by: Brendan Jackman <brendan.jackman@arm.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Josef Bacik <jbacik@fb.com> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com> Cc: Josef Bacik <josef@toxicpanda.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mike Galbraith <efault@gmx.de> Cc: Morten Rasmussen <morten.rasmussen@arm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20171005114516.18617-3-brendan.jackman@arm.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index dd4f253..bdd28fb 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -5933,7 +5933,7 @@ static inline int find_idlest_cpu(struct sched_domain *sd, struct task_struct *p } new_cpu = find_idlest_group_cpu(group, p, cpu); - if (new_cpu == -1 || new_cpu == cpu) { + if (new_cpu == cpu) { /* Now try balancing at a lower domain level of cpu */ sd = sd->child; continue;
| |