lkml.org 
[lkml]   [2017]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD
On Thu, 08 Dec 2016, Marek Vasut wrote:

> On 12/08/2016 11:27 PM, Ksenija Stanojevic wrote:
> > Add core files for low resolution analog-to-digital converter (mxs-lradc)
> > MFD driver.
> >
> > Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>
> Just a nit below.
>
> > +++ b/include/linux/mfd/mxs-lradc.h
> > @@ -0,0 +1,187 @@
> > +/*
>
> [...]
>
> > +#define LRADC_CTRL1_MX28_LRADC_IRQ_EN_MASK (0x1fff << 16)
> > +#define LRADC_CTRL1_MX23_LRADC_IRQ_EN_MASK (0x01ff << 16)
> > +#define LRADC_CTRL1_LRADC_IRQ_EN_OFFSET 16
> > +#define LRADC_CTRL1_TOUCH_DETECT_IRQ BIT(8)
> > +#define LRADC_CTRL1_LRADC_IRQ(n) (1 << (n))
>
> This would turn into BIT(n) , no ?

Once you have fixed this, you can apply my:

For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

> > +#define LRADC_CTRL1_MX28_LRADC_IRQ_MASK 0x1fff
> > +#define LRADC_CTRL1_MX23_LRADC_IRQ_MASK 0x01ff
> > +#define LRADC_CTRL1_LRADC_IRQ_OFFSET 0
>
> [...]
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2017-01-04 11:30    [W:0.066 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site