Messages in this thread | | | Subject | Re: [PATCH v11 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD | From | Marek Vasut <> | Date | Thu, 8 Dec 2016 23:56:28 +0100 |
| |
On 12/08/2016 11:27 PM, Ksenija Stanojevic wrote: > Add core files for low resolution analog-to-digital converter (mxs-lradc) > MFD driver. > > Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Just a nit below.
> +++ b/include/linux/mfd/mxs-lradc.h > @@ -0,0 +1,187 @@ > +/*
[...]
> +#define LRADC_CTRL1_MX28_LRADC_IRQ_EN_MASK (0x1fff << 16) > +#define LRADC_CTRL1_MX23_LRADC_IRQ_EN_MASK (0x01ff << 16) > +#define LRADC_CTRL1_LRADC_IRQ_EN_OFFSET 16 > +#define LRADC_CTRL1_TOUCH_DETECT_IRQ BIT(8) > +#define LRADC_CTRL1_LRADC_IRQ(n) (1 << (n))
This would turn into BIT(n) , no ?
> +#define LRADC_CTRL1_MX28_LRADC_IRQ_MASK 0x1fff > +#define LRADC_CTRL1_MX23_LRADC_IRQ_MASK 0x01ff > +#define LRADC_CTRL1_LRADC_IRQ_OFFSET 0
[...]
-- Best regards, Marek Vasut
| |