Messages in this thread | | | Date | Fri, 20 Jan 2017 16:00:26 +0100 | From | Johannes Thumshirn <> | Subject | Re: [PATCH v2 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices. |
| |
On Fri, Jan 20, 2017 at 08:12:11PM +0530, Chaitra P B wrote: > Small glitch/degraded performance in Crusader is improved with SAS > drives by removing unnecessary spinlocks while clearing scsi command > in drivers internal lookup table. > > Signed-off-by: Chaitra P B <chaitra.basappa@broadcom.com> > Signed-off-by: Suganath Prabu S <suganath-prabu.subramani@broadcom.com> > ---
Whats wrong with creating a __scsih_scsi_lookup_get_clear() and calling it with the scsi_lookup_lock held from _scsih_scsi_lookup_get_clear() instead of duplicating the code?
It's quite common in the linux kernel to have two functions func and __func, where func is
func() { spin_lock(); __func(); spin_unlock(); }
-- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
| |