Messages in this thread | | | Subject | Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses | From | Sergei Shtylyov <> | Date | Mon, 26 Sep 2016 20:38:14 +0300 |
| |
Hello.
On 09/26/2016 06:44 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net> > Date: Mon, 26 Sep 2016 17:03:56 +0200 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script "checkpatch.pl" can point information out like the following. > > WARNING: sizeof … should be sizeof(…) > > Thus fix the affected source code places. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/isdn/gigaset/common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c > index 2e9382f..d901ed7 100644 > --- a/drivers/isdn/gigaset/common.c > +++ b/drivers/isdn/gigaset/common.c > @@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const unsigned char *msg, > { > unsigned char outbuf[80]; > unsigned char c; > - size_t space = sizeof outbuf - 1; > + size_t space = sizeof(outbuf - 1);
What?! Does that compile?
[...]
MBR, Sergei
| |