lkml.org 
[lkml]   [2016]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses
    Date
    From: SF Markus Elfring
    > Sent: 26 September 2016 16:45
    ...
    > The script "checkpatch.pl" can point information out like the following.
    >
    > WARNING: sizeof … should be sizeof(…)
    ...
    > ---
    > drivers/isdn/gigaset/common.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c
    > index 2e9382f..d901ed7 100644
    > --- a/drivers/isdn/gigaset/common.c
    > +++ b/drivers/isdn/gigaset/common.c
    > @@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const unsigned char *msg,
    > {
    > unsigned char outbuf[80];
    > unsigned char c;
    > - size_t space = sizeof outbuf - 1;
    > + size_t space = sizeof(outbuf - 1);

    wrong ...
    think that is 7 instead of 79.

    David

    \
     
     \ /
      Last update: 2016-09-26 18:04    [W:3.244 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site