Messages in this thread | | | Subject | Re: [tip:x86/vdso] x86/vdso: Only define map_vdso_randomized() if CONFIG_X86_64 | From | Dmitry Safonov <> | Date | Thu, 15 Sep 2016 14:18:38 +0300 |
| |
On 09/15/2016 01:44 PM, tip-bot for Ingo Molnar wrote: > Commit-ID: 3947f49302e4d1576ee58addd8d20b477faef5ea > Gitweb: http://git.kernel.org/tip/3947f49302e4d1576ee58addd8d20b477faef5ea > Author: Ingo Molnar <mingo@kernel.org> > AuthorDate: Thu, 15 Sep 2016 08:56:21 +0200 > Committer: Ingo Molnar <mingo@kernel.org> > CommitDate: Thu, 15 Sep 2016 09:44:32 +0200 > > x86/vdso: Only define map_vdso_randomized() if CONFIG_X86_64 > > ... otherwise the compiler complains: > > arch/x86/entry/vdso/vma.c:252:12: warning: ‘map_vdso_randomized’ defined but not used [-Wunused-function] > > But the #ifdeffery here is getting pretty ugly, so move around > vdso_addr() as well to cluster the dependencies a bit more. > > It's still not particulary pretty though ... > > Cc: Andy Lutomirski <luto@kernel.org> > Cc: Borislav Petkov <bp@alien8.de> > Cc: Brian Gerst <brgerst@gmail.com> > Cc: Denys Vlasenko <dvlasenk@redhat.com> > Cc: Dmitry Safonov <dsafonov@virtuozzo.com> > Cc: H. Peter Anvin <hpa@zytor.com> > Cc: Josh Poimboeuf <jpoimboe@redhat.com> > Cc: Linus Torvalds <torvalds@linux-foundation.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: gorcunov@openvz.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: oleg@redhat.com > Cc: xemul@virtuozzo.com > Signed-off-by: Ingo Molnar <mingo@kernel.org> > ---
Thanks!
-- Dmitry
| |