lkml.org 
[lkml]   [2016]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] fix debugfs_simple_attr.cocci warnings (fwd)
I know nothing about the issues behind this, but I'm forwarding it in case
it's useful.

julia

---------- Forwarded message ----------
Date: Wed, 3 Aug 2016 13:26:56 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH] fix debugfs_simple_attr.cocci warnings

CC: kbuild-all@01.org
In-Reply-To: <1470170405-21530-1-git-send-email-andi@firstfloor.org>
TO: Andi Kleen <andi@firstfloor.org>
CC: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
CC: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>

kernel/panic.c:561:0-23: WARNING: clear_warn_once_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE

Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.

Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().

Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

CC: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

Please take the patch only if it's a positive warning. Thanks!

panic.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -558,16 +558,14 @@ static int clear_warn_once_set(void *dat
return 0;
}

-DEFINE_SIMPLE_ATTRIBUTE(clear_warn_once_fops,
- NULL,
- clear_warn_once_set,
- "%lld\n");
+DEFINE_DEBUGFS_ATTRIBUTE(clear_warn_once_fops, NULL, clear_warn_once_set,
+ "%lld\n");

static __init int register_warn_debugfs(void)
{
/* Don't care about failure */
- debugfs_create_file("clear_warn_once", 0644, NULL,
- NULL, &clear_warn_once_fops);
+ debugfs_create_file_unsafe("clear_warn_once", 0644, NULL, NULL,
+ &clear_warn_once_fops);
return 0;
}
\
 
 \ /
  Last update: 2016-08-03 14:21    [W:0.446 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site