Messages in this thread | | | Date | Mon, 22 Aug 2016 14:58:26 +0200 | From | David Hildenbrand <> | Subject | Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection |
| |
> From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 17 Aug 2016 19:25:50 +0200 > > The kfree() function was called in a few cases by the > kvm_s390_import_bp_data() function during error handling > even if a passed variable contained a null pointer. > > Adjust jump targets according to the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > arch/s390/kvm/guestdbg.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) >
Nack, we don't need micro optimization for error handling code. Adding more jump labels is never a good idea, it just increases complexity.
David
| |