lkml.org 
[lkml]   [2016]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection
    On Wed, 17 Aug 2016 20:10:37 +0200
    SF Markus Elfring <elfring@users.sourceforge.net> wrote:

    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Wed, 17 Aug 2016 19:25:50 +0200
    >
    > The kfree() function was called in a few cases by the
    > kvm_s390_import_bp_data() function during error handling
    > even if a passed variable contained a null pointer.
    >
    > Adjust jump targets according to the Linux coding style convention.

    NACK.

    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > arch/s390/kvm/guestdbg.c | 14 ++++++++------
    > 1 file changed, 8 insertions(+), 6 deletions(-)
    >

    > @@ -273,10 +273,12 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu,
    > vcpu->arch.guestdbg.nr_hw_wp = nr_wp;
    > vcpu->arch.guestdbg.hw_wp_info = wp_info;
    > return 0;
    > -error:
    > - kfree(bp_data);
    > - kfree(wp_info);
    > +free_bp_info:
    > kfree(bp_info);
    > +free_wp_info:
    > + kfree(wp_info);
    > +free_bp_data:
    > + kfree(bp_data);
    > return ret;
    > }
    >

    This replaces a perfectly fine fallthrough with some horrible labels.
    Please don't do that.

    \
     
     \ /
      Last update: 2016-09-17 09:57    [W:4.464 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site