lkml.org 
[lkml]   [2016]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 0276/1285] Replace numeric parameter like 0444 with macro
Date
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/input/keyboard/lm8323.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/keyboard/lm8323.c b/drivers/input/keyboard/lm8323.c
index 21bea52..78a0ca6 100644
--- a/drivers/input/keyboard/lm8323.c
+++ b/drivers/input/keyboard/lm8323.c
@@ -556,7 +556,7 @@ static ssize_t lm8323_pwm_store_time(struct device *dev,

return strlen(buf);
}
-static DEVICE_ATTR(time, 0644, lm8323_pwm_show_time, lm8323_pwm_store_time);
+static DEVICE_ATTR(time, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, lm8323_pwm_show_time, lm8323_pwm_store_time);

static struct attribute *lm8323_pwm_attrs[] = {
&dev_attr_time.attr,
@@ -625,7 +625,7 @@ static ssize_t lm8323_set_disable(struct device *dev,

return count;
}
-static DEVICE_ATTR(disable_kp, 0644, lm8323_show_disable, lm8323_set_disable);
+static DEVICE_ATTR(disable_kp, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, lm8323_show_disable, lm8323_set_disable);

static int lm8323_probe(struct i2c_client *client,
const struct i2c_device_id *id)
--
2.9.2
\
 
 \ /
  Last update: 2016-08-02 14:21    [W:0.025 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site