Messages in this thread Patch in this message | | | Date | Wed, 27 Jul 2016 14:50:43 +0530 | From | Bhaktipriya Shridhar <> | Subject | [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue |
| |
alloc_ordered_workqueue replaces the deprecated create_singlethread_workqueue.
The workqueue "workqueue" has multiple workitems which may require ordering. Hence, a dedicated ordered workqueue has been used. Since the workqueue is not being used on a memory reclaim path, WQ_MEM_RECLAIM has not been set.
Can the workitems run concurrently? Is the ordering among work items necessary?
Thanks.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> --- drivers/usb/host/u132-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c index 43d5293..cbde189 100644 --- a/drivers/usb/host/u132-hcd.c +++ b/drivers/usb/host/u132-hcd.c @@ -3206,7 +3206,7 @@ static int __init u132_hcd_init(void) if (usb_disabled()) return -ENODEV; printk(KERN_INFO "driver %s\n", hcd_name); - workqueue = create_singlethread_workqueue("u132"); + workqueue = alloc_ordered_workqueue("u132", 0); retval = platform_driver_register(&u132_platform_driver); return retval; } -- 2.1.4
| |