Messages in this thread | | | Date | Wed, 15 Jun 2016 11:07:17 -0700 | From | Matt Wilson <> | Subject | Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) |
| |
On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote: > This is a driver for the forthcoming ENA family of networking devices. > > Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
[...]
> + > +struct ena_napi { > + struct napi_struct napi ____cacheline_aligned; > + struct ena_ring *tx_ring; > + struct ena_ring *rx_ring; > +#ifndef HAVE_NETDEV_NAPI_LIST > + struct net_device poll_dev; > +#endif /* HAVE_NETDEV_NAPI_LIST */ > + u32 qid; > +};
Netanel,
Sorry I missed this when I read through the patch earlier this week (though I pointed it out before...). This "#ifndef HAVE_NETDEV_NAPI_LIST" bit needs to be removed for the in-tree version.
You also had a few typos in the email addresses on the Cc: line that I've corrected (davm@avemeloft.net -> davem@davemeloft.net, aligouri@amazon.com -> aliguori@amazon.com). Please make sure to correct in your v2 patch.
--msw
| |