Messages in this thread | | | Date | Tue, 14 Jun 2016 23:27:09 -0700 (PDT) | Subject | Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) | From | David Miller <> |
| |
From: Matt Wilson <msw@amzn.com> Date: Tue, 14 Jun 2016 23:23:36 -0700
> Point taken, though existing drivers (even fairly popular ones) also > aren't as clean as you might like. A quick look around...
Existing drivers do undesirable things, film at 11...
Yet are never a reason to accept such things in new drivers.
> Like many other network drivers, some of this is common code used for > non-Linux systems, and that's why there is some overlap with Linux > facilities.
Again, never an excuse for such things.
> Are there other things that jump out at you?
I review hundreds of patches a day, I invested what I was able to before moving on to other people's work.
Other developers must help review such a large driver submission, it can't all be on me.
| |