| From | Greg Kroah-Hartman <> | Subject | [PATCH 4.5 18/88] soc: rockchip: power-domain: fix err handle while probing | Date | Mon, 9 May 2016 09:21:07 +0200 |
| |
4.5-stable review patch. If anyone has any objections, please let me know.
------------------
From: Shawn Lin <shawn.lin@rock-chips.com>
commit 1d961f11a108af9f7fbe89cc950a8d16ddbdbb28 upstream.
If we fail to probe the driver, we should not directly break from the for_each_available_child_of_node since it calls of_node_get while iterating. This patch add of_node_put to fix the unbalanced call pair.
Fixes: 7c696693a4f5 ("soc: rockchip: power-domain: Add power domain driver") Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- drivers/soc/rockchip/pm_domains.c | 1 + 1 file changed, 1 insertion(+)
--- a/drivers/soc/rockchip/pm_domains.c +++ b/drivers/soc/rockchip/pm_domains.c @@ -419,6 +419,7 @@ static int rockchip_pm_domain_probe(stru if (error) { dev_err(dev, "failed to handle node %s: %d\n", node->name, error); + of_node_put(node); goto err_out; } }
|