lkml.org 
[lkml]   [2016]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.5 60/88] x86/tsc: Read all ratio bits from MSR_PLATFORM_INFO
    Date
    4.5-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Chen Yu <yu.c.chen@intel.com>

    commit 886123fb3a8656699dff40afa0573df359abeb18 upstream.

    Currently we read the tsc radio: ratio = (MSR_PLATFORM_INFO >> 8) & 0x1f;

    Thus we get bit 8-12 of MSR_PLATFORM_INFO, however according to the SDM
    (35.5), the ratio bits are bit 8-15.

    Ignoring the upper bits can result in an incorrect tsc ratio, which causes the
    TSC calibration and the Local APIC timer frequency to be incorrect.

    Fix this problem by masking 0xff instead.

    [ tglx: Massaged changelog ]

    Fixes: 7da7c1561366 "x86, tsc: Add static (MSR) TSC calibration on Intel Atom SoCs"
    Signed-off-by: Chen Yu <yu.c.chen@intel.com>
    Cc: "Rafael J. Wysocki" <rafael@kernel.org>
    Cc: Bin Gao <bin.gao@intel.com>
    Cc: Len Brown <lenb@kernel.org>
    Link: http://lkml.kernel.org/r/1462505619-5516-1-git-send-email-yu.c.chen@intel.com
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/x86/kernel/tsc_msr.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/kernel/tsc_msr.c
    +++ b/arch/x86/kernel/tsc_msr.c
    @@ -92,7 +92,7 @@ unsigned long try_msr_calibrate_tsc(void

    if (freq_desc_tables[cpu_index].msr_plat) {
    rdmsr(MSR_PLATFORM_INFO, lo, hi);
    - ratio = (lo >> 8) & 0x1f;
    + ratio = (lo >> 8) & 0xff;
    } else {
    rdmsr(MSR_IA32_PERF_STATUS, lo, hi);
    ratio = (hi >> 8) & 0x1f;

    \
     
     \ /
      Last update: 2016-05-09 10:01    [W:4.162 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site