Messages in this thread | | | From | Nicolai Stange <> | Subject | [PATCH 0/3] debugfs: fixes to "file removal race" series | Date | Tue, 24 May 2016 13:08:51 +0200 |
| |
Hi Greg,
the recent report by Sasha Levin made me review my debugfs "file removal race" series again.
For your reference, the original series in question was posted here: http://lkml.kernel.org/g/1458652280-19785-1-git-send-email-nicstange@gmail.com It has been merged through your driver-core tree into mainline.
Unfortunately, I found three issues:
The first one is a minor code style issue. The second one is more serious: on ->open() failure, references to modules as well as memory are leaked. The third one is a potential leak of module references with future debugfs users.
The patches don't depend on each other and are unrelated except that they all address issues introduced by the same series. I tested them with linux-next 20160523.
Apologies and thanks,
Nicolai
Nicolai Stange (3): debugfs: remove extra debugfs_create_file_unsafe() declaration debugfs: full_proxy_open(): free proxy on ->open() failure debugfs: open_proxy_open(): avoid double fops release
fs/debugfs/file.c | 7 ++++--- fs/debugfs/internal.h | 4 ---- 2 files changed, 4 insertions(+), 7 deletions(-)
-- 2.8.2
| |