lkml.org 
[lkml]   [2016]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/27] block: bio: introduce 4 helpers for cleanup
On Tue, Apr 05, 2016 at 07:56:46PM +0800, Ming Lei wrote:
> Some drivers access bio->bi_vcnt and bio->bi_io_vec directly,
> firstly it isn't a good practice, secondly it may cause trouble
> for converting to multipage bvecs.

"not good practice" is OO bullshit snake oil without more justification. We
don't plaster accessors everywhere without an actual reason.

How would it cause trouble with multipage bvecs?

\
 
 \ /
  Last update: 2016-04-06 02:41    [W:0.184 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site