| Date | Tue, 5 Apr 2016 14:42:38 +0200 | From | Lars Ellenberg <> | Subject | Re: [PATCH 03/27] block: drbd: remove impossible failure handling |
| |
On Tue, Apr 05, 2016 at 07:56:48PM +0800, Ming Lei wrote: > For a non-cloned bio, bio_add_page() only returns failure when > the io vec table is full, but in that case, bio->bi_vcnt can't > be zero at all. > > So remove the impossible failure handling.
Before the immutable bvecs, we did in fact see this trigger in the wild. On "strange" deployments.
But for the current implementation of bio_add_page(), you are correct, this is impossible now.
Ack.
Thanks,
Lars
|