Messages in this thread Patch in this message | | | Date | Thu, 14 Apr 2016 08:54:30 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH] mtd: nand: omap2: fix compare_const_fl.cocci warnings |
| |
Move constants to the right of binary operators.
Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
CC: Rafał Miłecki <zajec5@gmail.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> ---
It's minor point, but I think it would look a bit nicer, since one would see the important thing (is_write) first.
omap2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -208,7 +208,7 @@ static int omap_prefetch_enable(int cs, */ val = ((cs << PREFETCH_CONFIG1_CS_SHIFT) | PREFETCH_FIFOTHRESHOLD(fifo_th) | ENABLE_PREFETCH | - (dma_mode << DMA_MPU_MODE_SHIFT) | (0x1 & is_write)); + (dma_mode << DMA_MPU_MODE_SHIFT) | (is_write & 0x1)); writel(val, info->reg.gpmc_prefetch_config1); /* Start the prefetch engine */ | |