lkml.org 
[lkml]   [2016]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Skein:move macros into appropriate header files
On Wed, Mar 30, 2016 at 08:51:42AM +0800, Ming Li wrote:
> hi, i move macros into header files.
>
>
> regards,
>
>
> Signed-off-by: Ming Li <mingli199x@qq.com>

That's a very strange changelog comment, can you please expand on what
you are doing this for?

You need to explain _why_ you are doing something, not what you are
doing.

thanks,

greg k-h

\
 
 \ /
  Last update: 2016-03-30 03:21    [W:3.186 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site