lkml.org 
[lkml]   [2016]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 20/22] atari_scsi: Set a reasonable default for cmd_per_lun
From
Date
On 03/14/2016 05:27 AM, Finn Thain wrote:
> This setting does not need to be conditional on Atari ST or TT.
>
> Without TCQ support, cmd_per_lun == 2 is probably reasonable...
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
> ---
> drivers/scsi/atari_scsi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: linux/drivers/scsi/atari_scsi.c
> ===================================================================
> --- linux.orig/drivers/scsi/atari_scsi.c 2016-03-14 15:26:45.000000000 +1100
> +++ linux/drivers/scsi/atari_scsi.c 2016-03-14 15:26:55.000000000 +1100
> @@ -750,6 +750,7 @@ static struct scsi_host_template atari_s
> .eh_abort_handler = atari_scsi_abort,
> .eh_bus_reset_handler = atari_scsi_bus_reset,
> .this_id = 7,
> + .cmd_per_lun = 2,
> .use_clustering = DISABLE_CLUSTERING,
> .cmd_size = NCR5380_CMD_SIZE,
> };
_2_ ? Are you being overly cheeky here?
I sincerely doubt the driver is capable of submitting two
simultaneous commands ...
Care to explain?

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

\
 
 \ /
  Last update: 2016-03-14 09:21    [W:0.283 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site