lkml.org 
[lkml]   [2016]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 22/22] mac_scsi: Fix pseudo DMA implementation
    From
    Date
    On 03/14/2016 05:27 AM, Finn Thain wrote:
    > Fix various issues: Comments about bus errors are incorrect. The
    > PDMA asm must return the size of the memory access that faulted so the
    > transfer count can be adjusted accordingly. A phase change may cause a
    > bus error but should not be treated as failure. A bus error does not
    > always imply a phase change and generally the transfer may continue.
    > Scatter/gather can't be used with PDMA due to overruns (which is a pity
    > because peak throughput seems to double with SG_ALL).
    >
    > Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
    >
    > ---
    > drivers/scsi/NCR5380.h | 2
    > drivers/scsi/mac_scsi.c | 210 ++++++++++++++++++++++++++----------------------
    > 2 files changed, 118 insertions(+), 94 deletions(-)
    >
    Reviewed-by: Hannes Reinecke <hare@suse.com>

    Cheers,

    Hannes
    --
    Dr. Hannes Reinecke Teamlead Storage & Networking
    hare@suse.de +49 911 74053 688
    SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
    GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
    HRB 21284 (AG Nürnberg)

    \
     
     \ /
      Last update: 2016-03-14 09:41    [W:6.182 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site