lkml.org 
[lkml]   [2016]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] devm_memremap_release: fix memremap'd addr handling
On Tue, 16 Feb 2016 09:30:27 -0700 Toshi Kani <toshi.kani@hpe.com> wrote:

> The pmem driver calls devm_memremap() to map a persistent memory
> range. When the pmem driver is unloaded, this memremap'd range
> is not released.
>
> Fix devm_memremap_release() to handle a given memremap'd address
> properly.
>
> ...
>
> --- a/kernel/memremap.c
> +++ b/kernel/memremap.c
> @@ -114,7 +114,7 @@ EXPORT_SYMBOL(memunmap);
>
> static void devm_memremap_release(struct device *dev, void *res)
> {
> - memunmap(res);
> + memunmap(*(void **)res);
> }
>

Huh. So what happens? memunmap() decides it isn't a vmalloc address
and we leak a vma?

I'll add a cc:stable to this.

\
 
 \ /
  Last update: 2016-02-17 01:41    [W:0.851 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site