Messages in this thread | | | Date | Tue, 16 Feb 2016 16:40:48 -0800 | Subject | Re: [PATCH] devm_memremap_release: fix memremap'd addr handling | From | Dan Williams <> |
| |
On Tue, Feb 16, 2016 at 8:30 AM, Toshi Kani <toshi.kani@hpe.com> wrote: > The pmem driver calls devm_memremap() to map a persistent memory > range. When the pmem driver is unloaded, this memremap'd range > is not released. > > Fix devm_memremap_release() to handle a given memremap'd address > properly. > > Signed-off-by: Toshi Kani <toshi.kani@hpe.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > --- > kernel/memremap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/memremap.c b/kernel/memremap.c > index 2c468de..7a1b5c3 100644 > --- a/kernel/memremap.c > +++ b/kernel/memremap.c > @@ -114,7 +114,7 @@ EXPORT_SYMBOL(memunmap); > > static void devm_memremap_release(struct device *dev, void *res) > { > - memunmap(res); > + memunmap(*(void **)res); > }
Ugh, yup. Thanks Toshi!
Acked-by: Dan Williams <dan.j.williams@intel.com>
| |