Messages in this thread | | | Date | Wed, 17 Feb 2016 02:33:10 +0000 | From | Al Viro <> | Subject | Re: [PATCH 3/7] drivers: char: mem: fix IS_ERROR_VALUE usage |
| |
On Mon, Feb 15, 2016 at 03:35:21PM +0100, Andrzej Hajda wrote: > diff --git a/drivers/char/mem.c b/drivers/char/mem.c > index 4f6f94c..71025c2 100644 > --- a/drivers/char/mem.c > +++ b/drivers/char/mem.c > @@ -695,7 +695,7 @@ static loff_t memory_lseek(struct file *file, loff_t offset, int orig) > offset += file->f_pos; > case SEEK_SET: > /* to avoid userland mistaking f_pos=-9 as -EBADF=-9 */ > - if (IS_ERR_VALUE((unsigned long long)offset)) { > + if ((unsigned long long)offset >= -MAX_ERRNO) { > ret = -EOVERFLOW; > break; > }
ACK
| |