lkml.org 
[lkml]   [2016]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/7] fbdev: exynos: fix IS_ERR_VALUE usage
    Date
    IS_ERR_VALUE macro should be used only with unsigned long type.
    For signed types comparison 'ret < 0' should be used.

    The patch follows conclusion from discussion on LKML [1][2].

    [1]: http://permalink.gmane.org/gmane.linux.kernel/2120927
    [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581

    Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
    ---
    drivers/video/fbdev/exynos/exynos_mipi_dsi.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/video/fbdev/exynos/exynos_mipi_dsi.c b/drivers/video/fbdev/exynos/exynos_mipi_dsi.c
    index b527fe4..951b592 100644
    --- a/drivers/video/fbdev/exynos/exynos_mipi_dsi.c
    +++ b/drivers/video/fbdev/exynos/exynos_mipi_dsi.c
    @@ -402,12 +402,12 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev)
    goto error;
    }

    - dsim->irq = platform_get_irq(pdev, 0);
    - if (IS_ERR_VALUE(dsim->irq)) {
    + ret = platform_get_irq(pdev, 0);
    + if (ret < 0) {
    dev_err(&pdev->dev, "failed to request dsim irq resource\n");
    - ret = -EINVAL;
    goto error;
    }
    + dsim->irq = ret;

    init_completion(&dsim_wr_comp);
    init_completion(&dsim_rd_comp);
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-02-15 16:01    [W:4.031 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site