lkml.org 
[lkml]   [2016]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] leds: pca9532: fix device_node_continue.cocci warnings
Device node iterators put the previous value of the index variable, so an
explicit put causes a double put.

Generated by: scripts/coccinelle/iterators/device_node_continue.cocci

Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

I haven't looked at the context in detail, but given the rule, I assume
that there is an iterator, such as for_each_child_of_node, and these
iterators do a put on each iteration, so none is needed in the loop body.

tree: https://github.com/manabian/linux-lpc lpc18xx_43xx_devel
head: 9ee5f58bbb16c08da223c4b4933457e0eb72268d
commit: c58957273142be779f62c17fae389ce9c134139f [44/55] leds: pca9532: use

leds-pca9532.c | 3 ---
1 file changed, 3 deletions(-)

--- a/drivers/leds/leds-pca9532.c
+++ b/drivers/leds/leds-pca9532.c
@@ -473,7 +473,6 @@ pca9532_of_populate_pdata(struct device

res = of_property_read_u32(child, "reg", &reg);
if ((res != 0) || (reg >= maxleds)) {
- of_node_put(child);
continue;
}

@@ -484,8 +483,6 @@ pca9532_of_populate_pdata(struct device
of_property_read_u32(child, "type", &pdata->leds[reg].type);
of_property_read_string(child, "linux,default-trigger",
&pdata->leds[reg].default_trigger);
-
- of_node_put(child);
}

return pdata;
\
 
 \ /
  Last update: 2016-12-29 22:11    [W:0.113 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site