lkml.org 
[lkml]   [2016]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] phy: rockchip-inno-usb2: add extcon dependency
Date
If extcon is a loadable module and rockchip-inno-usb2 is built-in,
we get a link failure:

drivers/phy/phy-rockchip-inno-usb2.o: In function `rockchip_usb2phy_probe':
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x1ec): undefined reference to `extcon_get_edev_by_phandle'
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x25c): undefined reference to `devm_extcon_dev_allocate'
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x2a8): undefined reference to `devm_extcon_dev_register'
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0xa28): undefined reference to `extcon_register_notifier'

Adding a hard dependency avoids the problem. Alternatively we could
use "depends on EXTCON || !EXTCON" to allow building with extcon
disabled completely, but the other PHY drivers with extcon support
also just have a dependency, so this is more consistent.

Fixes: 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 53cab9f3323b..b135ff1ab12d 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -366,6 +366,7 @@ config PHY_ROCKCHIP_INNO_USB2
depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
depends on COMMON_CLK
depends on USB_SUPPORT
+ depends on EXTCON
select GENERIC_PHY
select USB_COMMON
help
--
2.9.0
\
 
 \ /
  Last update: 2016-11-18 17:38    [W:0.613 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site