lkml.org 
[lkml]   [2016]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: drivers/block/rbd.c:838: bad if expression ?
On Tue, Nov 15, 2016 at 11:38 AM, David Binderman <dcb314@hotmail.com> wrote:
> Hello there,
>
> drivers/block/rbd.c:838:34: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]
>
> Source code is
>
> } else if (token > Opt_last_int && token < Opt_last_string) {
>
> but
>
> enum {
> Opt_queue_depth,
> Opt_last_int,
> /* int args above */
> Opt_last_string,

Hi David,

It's just a placeholder for any string options that might be added in
the future. See opt_tokens definition in net/ceph/ceph_common.c for an
example (fsid, secret, etc).

Thanks,

Ilya

\
 
 \ /
  Last update: 2016-11-15 14:08    [W:0.055 / U:1.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site