lkml.org 
[lkml]   [2016]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] phy-rockchip-pcie: remove deassert of phy_rst from exit callback
Date
Am Donnerstag, 13. Oktober 2016, 12:42:13 CEST schrieb Shawn Lin:
> The deassert of phy_rst from exit callback is incorrect as when
> doing phy_exit, we expect the phy_rst is on asserted state which was
> done by power_off callback, but not deasserted state. Meanwhile when
> disabling clk_pciephy_ref, the assert/deassert signal can't actually
> take effect on the phy. So let's fix it anyway.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

looks ok to have that removed, as any future phy_init call will make sure it
gets asserted anyway.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

\
 
 \ /
  Last update: 2016-10-28 10:31    [W:0.104 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site