Messages in this thread | | | Date | Mon, 4 Jan 2016 09:11:31 +0100 | From | Boris Brezillon <> | Subject | Re: [PATCH 01/19] irqchip: atmel-aic: fix wrong bit operation for IRQ priority |
| |
Hi Milo,
On Mon, 4 Jan 2016 13:28:25 +0900 Milo Kim <milo.kim@ti.com> wrote:
> Atmel AIC has common structure for SMR (Source Mode Register). > > bit[6:5] Interrupt source type > bit[2:0] Priority level > Other bits are unused. > > To update new priority value, bit[2:0] should be cleared first and then > new priority level can be written. However, aic_common_set_priority() > helper clears source type bits instead of priority bits. > This patch fixes wrong mask bit operation. > > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Marc Zyngier <marc.zyngier@arm.com> > Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com> > Cc: Boris BREZILLON <boris.brezillon@free-electrons.com> > Cc: Ludovic Desroches <ludovic.desroches@atmel.com> > Cc: Nicolas Ferre <nicolas.ferre@atmel.com> > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Milo Kim <milo.kim@ti.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Can you also add
Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers") Cc: stable@vger.kernel.org #v3.17+
Thanks,
Boris
> --- > drivers/irqchip/irq-atmel-aic-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-atmel-aic-common.c b/drivers/irqchip/irq-atmel-aic-common.c > index b12a5d5..37199b9 100644 > --- a/drivers/irqchip/irq-atmel-aic-common.c > +++ b/drivers/irqchip/irq-atmel-aic-common.c > @@ -86,7 +86,7 @@ int aic_common_set_priority(int priority, unsigned *val) > priority > AT91_AIC_IRQ_MAX_PRIORITY) > return -EINVAL; > > - *val &= AT91_AIC_PRIOR; > + *val &= ~AT91_AIC_PRIOR; > *val |= priority; > > return 0;
-- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
| |